Let repos define the release PR body - #266
Merged
Merged
Conversation
Release PRs were created with an empty body. Repos whose CI is triggered from the PR body, such as Tekton reading '/run cluster-test-suites', therefore never ran their tests on a release PR unless someone remembered to comment - and provider chart releases were being merged with no E2E run at all. If a repo ships .github/release-pr-body.md its contents are used as the body. Repos without the file keep an empty body.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
njuettner
added a commit
to giantswarm/cluster-aws
that referenced
this pull request
Aug 6, 2026
Release PRs are created with an empty body, so Tekton - which starts the tests from a /run line in the PR body - never ran anything on them, and releases were merged with no E2E run at all. giantswarm/github-workflows#266 makes the release PR body come from this file when present. cluster-test-suites already expands to every suite for this provider once it detects a release PR, so no suite parameters are needed.
njuettner
added a commit
to giantswarm/cluster-azure
that referenced
this pull request
Aug 6, 2026
Release PRs are created with an empty body, so Tekton - which starts the tests from a /run line in the PR body - never ran anything on them, and releases were merged with no E2E run at all. giantswarm/github-workflows#266 makes the release PR body come from this file when present. cluster-test-suites already expands to every suite for this provider once it detects a release PR, so no suite parameters are needed.
mproffitt
approved these changes
Aug 6, 2026
zizmor flags the gh pr create line for code injection via template expansion: github.actor, the base, branch and version were interpolated into the script before it ran. They now come from the step environment as shell variables, which is also quoted correctly.
This was referenced Aug 6, 2026
Merged
njuettner
added a commit
to giantswarm/cluster-aws
that referenced
this pull request
Aug 7, 2026
Release PRs are created with an empty body, so Tekton - which starts the tests from a /run line in the PR body - never ran anything on them, and releases were merged with no E2E run at all. giantswarm/github-workflows#266 makes the release PR body come from this file when present. cluster-test-suites already expands to every suite for this provider once it detects a release PR, so no suite parameters are needed.
njuettner
added a commit
to giantswarm/cluster-eks
that referenced
this pull request
Aug 7, 2026
Release PRs are created with an empty body, so Tekton - which starts the tests from a /run line in the PR body - never ran anything on them, and releases were merged with no E2E run at all. giantswarm/github-workflows#266 makes the release PR body come from this file when present. cluster-test-suites already expands to every suite for this provider once it detects a release PR, so no suite parameters are needed.
njuettner
added a commit
to giantswarm/cluster-azure
that referenced
this pull request
Aug 7, 2026
Release PRs are created with an empty body, so Tekton - which starts the tests from a /run line in the PR body - never ran anything on them, and releases were merged with no E2E run at all. giantswarm/github-workflows#266 makes the release PR body come from this file when present. cluster-test-suites already expands to every suite for this provider once it detects a release PR, so no suite parameters are needed.
njuettner
added a commit
to giantswarm/cluster-vsphere
that referenced
this pull request
Aug 7, 2026
Release PRs are created with an empty body, so Tekton - which starts the tests from a /run line in the PR body - never ran anything on them, and releases were merged with no E2E run at all. giantswarm/github-workflows#266 makes the release PR body come from this file when present. cluster-test-suites already expands to every suite for this provider once it detects a release PR, so no suite parameters are needed.
njuettner
added a commit
to giantswarm/cluster-cloud-director
that referenced
this pull request
Aug 7, 2026
Release PRs are created with an empty body, so Tekton - which starts the tests from a /run line in the PR body - never ran anything on them, and releases were merged with no E2E run at all. giantswarm/github-workflows#266 makes the release PR body come from this file when present. cluster-test-suites already expands to every suite for this provider once it detects a release PR, so no suite parameters are needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards giantswarm/roadmap#4334
create-release-prcreates release PRs with--body "". Tekton auto-runs a repo's E2E tests by reading/run ...from the PR body — that is how the normal PR template triggers them — so release PRs triggered nothing. Running the tests depended on someone remembering to comment, and provider chart releases were merged with no E2E run at all:With this change, a repo that ships
.github/release-pr-body.mdgets its contents as the release PR body. Repos without the file keep an empty body, exactly as today.The provider chart repos will add that file containing
/run cluster-test-suites; the pipeline already expands to every suite for the provider when it detects a release PR, so the extended set runs without further parameters. App repos can opt in the same way with/run app-test-suites.Chosen over a central trigger with a hardcoded repo list (giantswarm/tekton-resources#930, now closed): each repo declares itself, so there is no list to maintain, repos without test suites simply do not add the file, and it is visible in the PR what will run.
The file is read from the checked-out release branch in the same job that creates the PR, so no extra checkout is needed.