feat: Run the full E2E suite set automatically on release PRs - #218
Merged
Conversation
Release PRs are created with an empty body, so Tekton - which starts the tests from a /run line in the PR body - never ran anything on them, and releases were merged with no E2E run at all. giantswarm/github-workflows#266 makes the release PR body come from this file when present. cluster-test-suites already expands to every suite for this provider once it detects a release PR, so no suite parameters are needed.
|
There were no differences in the rendered Helm template. Output |
Gacko
approved these changes
Aug 6, 2026
Member
Author
|
/skip-ci This change does not affect what's being tested by CI. |
njuettner
enabled auto-merge (squash)
August 7, 2026 09:26
|
🚨 CI checks were skipped Skip reason: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards giantswarm/roadmap#4334
Release PRs are created with an empty body, so Tekton — which starts the tests from a
/runline in the PR body — never ran anything on them. Running the E2E tests depended on someone remembering to comment, and release PRs were merged with no run at all (cluster-aws#2036, cluster-cloud-director#573, cluster-vsphere#527).Adds
.github/release-pr-body.md, which giantswarm/github-workflows#266 uses as the release PR body.cluster-test-suitesalready expands to every suite for this provider once it detects a release PR, so no suite parameters are needed here.Has no effect until giantswarm/github-workflows#266 merges; until then the file is simply unused.