feat(gen): add --auto-release-level flag, fix release-please App secrets - #1847
Merged
Conversation
Add an `--auto-release-level` flag (none|patch|minor|major; default none) to `gen workflows`, used with `--release-workflow=release-please`. It sets the `auto-merge-level` input of the giantswarm/github-workflows release.yaml reusable workflow, which auto-merges the Release Please PR when CI passes, up to the given bump level. Also fix the generated release-please.yaml secrets: it now passes RELEASE_PLEASE_CLIENT_ID and RELEASE_PLEASE_PRIVATE_KEY (matching the reusable workflow's App-based auth, where RELEASE_PLEASE_CLIENT_ID feeds create-github-app-token's client-id) instead of TAYLORBOT_GITHUB_ACTION.
QuentinBisson
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Lets repositories opt the release-please workflow into auto-merging its Release PR, by wiring devctl to the
auto-merge-levelinput added to thegiantswarm/github-workflowsrelease.yamlreusable workflow (giantswarm/github-workflows#185, merged).gen workflowsflag--auto-release-level(none|patch|minor|major; defaultnone), only meaningful with--release-workflow=release-please. It sets the reusable workflow'sauto-merge-levelinput. Invalid values are rejected at gen time.TAYLORBOT_GITHUB_ACTION, but the reusable workflow switched to GitHub App auth and now requiresRELEASE_PLEASE_CLIENT_ID+RELEASE_PLEASE_PRIVATE_KEY(the former feedscreate-github-app-token'sclient-id). The generatedrelease-please.yamlwas therefore non-functional againstrelease.yaml@main; this corrects it.Generated output
--auto-release-level minor:Default (no flag) renders
auto-merge-level: none.Relationship to other PRs
RELEASE_PLEASE_APP_ID; the reusable workflow requiresRELEASE_PLEASE_CLIENT_ID, notAPP_ID). Suggest closing feat(gen): release-please workflow passes GitHub App secrets #1843 in favor of this. The auth wiring originates in feat: add release-please workflow generation #1831.Consuming-repo prerequisites for auto-merge
RELEASE_PLEASE_CLIENT_IDandRELEASE_PLEASE_PRIVATE_KEYavailable as org/repo secrets.release-pleaseGitHub App on the default branch's protection/ruleset bypass list.Verification
go generate ./... && go build ./...andgo test ./pkg/gen/input/workflows/... ./cmd/gen/workflows/...pass;gofmt/go vetclean.minor, default (none), and an invalid value (rejected by validation).