feat(gen): release-please workflow passes GitHub App secrets - #1843
Closed
fiunchinho wants to merge 1 commit into
Closed
feat(gen): release-please workflow passes GitHub App secrets#1843fiunchinho wants to merge 1 commit into
fiunchinho wants to merge 1 commit into
Conversation
The generated release-please.yaml workflow now passes RELEASE_PLEASE_APP_ID and RELEASE_PLEASE_PRIVATE_KEY to the giantswarm/github-workflows release.yaml reusable workflow, matching the App-based authentication introduced there in giantswarm/github-workflows#181. The previous TAYLORBOT_GITHUB_ACTION PAT is no longer accepted by the reusable workflow.
Member
Author
|
Superseeded by #1847 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the
release_please.yaml.templateso the generatedrelease-please.yamlworkflow in consumer repos passes the new GitHub App secrets (RELEASE_PLEASE_CLIENT_ID,RELEASE_PLEASE_PRIVATE_KEY) to thegiantswarm/github-workflowsrelease.yamlreusable workflow, instead of the oldTAYLORBOT_GITHUB_ACTIONPAT.This is the consumer-side follow-up to giantswarm/github-workflows#181, which switched the reusable workflow's authentication to a GitHub App token minted via
actions/create-github-app-token(client-id:input).Why
RELEASE_PLEASE_CLIENT_IDandRELEASE_PLEASE_PRIVATE_KEYare organization-level secrets accessible to all repositories.fix_vulnerabilities.yaml.template.Scope
Only
release_please.yaml.templateis updated. Other templates (create_release,create_release_pr,update_chart) still passTAYLORBOT_GITHUB_ACTIONbecause the reusable workflows they call have not migrated yet.Sequencing
release-please.yamlin each consumer repo (devctl gen workflows --release-workflow=release-please).If this PR is merged before #181, repos regenerated in the window will fail their release workflow until #181 lands.
Test plan
devctl gen workflows --release-workflow=release-pleaseagainst a scratch repo and confirm the generated.github/workflows/release-please.yamlpassesRELEASE_PLEASE_CLIENT_IDandRELEASE_PLEASE_PRIVATE_KEYand no longer referencesTAYLORBOT_GITHUB_ACTION.mainproduces a release PR opened by the GitHub App.