docs(downloads): add TradeJournal Sync EA setup guide - #2
Merged
Conversation
…unctuation The Downloads setup guide covered the Master and Follower EAs but never documented the TradeJournal Sync EA. Add a dedicated step for it and fix a pre-existing rendering bug in the same guide. - New "Step 6: Install & Configure TradeJournal Sync EA": framed as independent of copy-trading (attach to any account, standalone, one chart per account), with a parameter table for the EA's real inputs (API_Key, API_Secret, API_Endpoint, AccountID, SyncIntervalSeconds, HeartbeatIntervalMs) and a required-fields / WebRequest note. - Renumber Verify Connection to Step 7 and split it into Master/Follower (green-dot panel) vs TradeJournal Sync (no panel -> [Journal] heartbeat log lines + dashboard Journal). - Fix literal — / → escapes that JSX rendered verbatim on the live page (Step 2 arrows, verify em-dash); use HTML entities (—, →) matching the convention already used elsewhere in the file. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ghwmelite-dotcom
added a commit
that referenced
this pull request
Jul 1, 2026
…essions (#3) Bring account credentials to the point of use so a journaling-only user no longer has to hunt on the copy-trading ("Copier") page for keys. - Add an "EA Credentials" panel to every EA download card showing the matching account's Account ID + API Key with Copy buttons. The one-time API Secret is exposed via a "Regenerate to reveal secret" action (reuses POST /accounts/:id/regenerate-keys), which reveals a fresh Key + Secret once with a save-now warning. Cards with no matching account link to the Copier page instead. - Add a shared "Where to find these" callout to the Master/Journal setup steps, and use the real page name ("Copier") consistently. - Fix two rendering bugs shipped in #2: `—` / `→` were placed inside JS string literals (journal card description, troubleshooting), where they render literally instead of as — / →. JS strings now use the real character; JSX text keeps HTML entities. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Downloads & Setup guide documented the Master and Follower EAs but had no setup instructions for the TradeJournal Sync EA. This adds a dedicated step and fixes a pre-existing rendering bug in the same guide.
Changes (frontend only —
DownloadsPage.tsx)New "Step 6: Install & Configure TradeJournal Sync EA" — framed as independent of copy-trading (attach to any account, run standalone, one chart per account; captures the whole account in real time + a one-time history catch-up). Includes a parameter table for the EA's actual inputs (verified against
apps/ea/TradeJournal_Sync.mq5):API_KeyAPI_SecretAPI_Endpointhttps://edgerelay-journal-sync.ghwmelite.workers.devAccountIDSyncIntervalSeconds60HeartbeatIntervalMs30000Renumbered Verify Connection → Step 7, split into Master/Follower (green-dot panel) vs TradeJournal Sync (no on-chart panel → check
[Journal]heartbeat lines in the Experts tab + confirm trades in the dashboard Journal). Confirmed via source that this EA has noComment()/chart display.Incidental fix
Several steps stored em-dashes/arrows as literal
—/→, which JSX renders verbatim on the live site (e.g. Step 2 showed "Tools → Options"). Converted to HTML entities (—,→) — the convention already used elsewhere in the file (File → Open Data Folder). A couple of already-correct em-dashes were also normalized to entities for consistency.Verification
JSX structure verified (Steps 6/7 well-formed,
setupStepsarray intact);grepconfirms 0 literal escapes remain.tscnot run locally (no TypeScript in the dev env) — CI Typecheck gates the deploy.🤖 Generated with Claude Code