feat(downloads): inline EA credentials on each card - #3
Merged
Conversation
…essions
Bring account credentials to the point of use so a journaling-only user no
longer has to hunt on the copy-trading ("Copier") page for keys.
- Add an "EA Credentials" panel to every EA download card showing the
matching account's Account ID + API Key with Copy buttons. The one-time
API Secret is exposed via a "Regenerate to reveal secret" action (reuses
POST /accounts/:id/regenerate-keys), which reveals a fresh Key + Secret
once with a save-now warning. Cards with no matching account link to the
Copier page instead.
- Add a shared "Where to find these" callout to the Master/Journal setup
steps, and use the real page name ("Copier") consistently.
- Fix two rendering bugs shipped in #2: `—` / `→` were placed
inside JS string literals (journal card description, troubleshooting),
where they render literally instead of as — / →. JS strings now use the
real character; JSX text keeps HTML entities.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the confusion where a journaling-only user had to visit the copy-trading "Copier" page to fetch API credentials. Now the credentials appear inline on each EA download card, right where you download and configure the EA.
Changes (frontend only —
DownloadsPage.tsx)POST /accounts/:id/regenerate-keys, and reveals a fresh Key + Secret once with a save-now note.Bug fixes (regressions from #2 — currently live)
PR #2 placed
—/→inside JS string literals (not JSX text), where entities render literally. The live site currently shows "zero drops — real-time" (journal card) and "Tools → Options" (troubleshooting). Both fixed here — JS strings use the real character; JSX text keeps entities.Verification
tsc/vite buildnot runnable locally (nonode_modulesin this workspace) — CI Typecheck gates the deploy. Regenerate reuses the same endpoint the Accounts page already uses.🤖 Generated with Claude Code