Repository navigation
www: extract hardcoded UI strings into i18n translation dictionary - #142
Merged
Merged
Conversation
Adds Starlight's i18n content collection (src/content/i18n/{en,zh-CN}.json)
and wires every custom component's hardcoded English string through
Astro.locals.t(): nav, footer, hero, the scenario browser and playground
(including client-side script strings passed in via a JSON island),
both diagrams, and the scenario detail page. Locale-aware internal links
now prefix with the current locale where a translated route exists.
zh-CN values are a first-pass machine translation of short UI strings
(labels, buttons, empty states) — good enough to unblock the routing/
rendering work, but worth a native-speaker pass before relying on it
for anything customer-facing. Scenario data/doc content is still
untranslated (out of scope here — it lives in the main package's
src/scenarios, not www/).
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…tionary Continuation of 54ffc9b — the component edits (config.ts collection registration, SiteTitle, Footer, HeroPlumbing, ScenarioBrowser, ScenarioPlayground, DiagramConflicts, DiagramPipeline) didn't get staged in that commit due to a shell glob error on the [name].astro path. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
3 tasks done
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
i18ncontent collection (src/content/config.ts) backed bysrc/content/i18n/{en,zh-CN}.jsonAstro.locals.t()lookups:SiteTitle,Footer,HeroPlumbing(homepage hero),ScenarioBrowser,ScenarioPlayground,DiagramConflicts,DiagramPipeline, and the scenario detail page (pages/scenarios/[name].astro)<script>strings (copy-button labels, commit-detail panel labels in the playground) are passed from the server viadata-*attributes / a JSON island, since scripts run in the browser and can't callAstro.locals.t()directly/zh-cn/...) where a translated route exists_one/_othersuffixes) for counted strings like "N contracts" / "N commits"Builds on #141 (Starlight locale scaffold). No doc content or scenario data is translated — this is UI-chrome only, per the earlier i18n audit's "moderate effort" tier.
Caveats
www/'s scope — scenario copy is generated from the main package'ssrc/scenarios/)Test plan
npm run buildcompletes cleanly, 114 pages including all/zh-cn/...routesenandzh-cn): nav, footer, hero, scenario browser filters + pluralized contract/line counts, playground commit-detail panel labels, copy-to-clipboard label swap (mocked clipboard API to bypass automation sandboxing), scenario detail page tabs/copy buttons🤖 Generated with Claude Code