Skip to content

Add sgb-ext-test #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avivace merged 2 commits into from
May 25, 2026
Merged

Add sgb-ext-test #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b633d7c
Add sgb-ext-test
CasualPokePlayer May 23, 2026
c59681f
Try fixing syntax
CasualPokePlayer May 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions testroms/cpp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,6 @@
description="Writes random values to RTC regs, reports them back, then latches the RTC using a single write to the 0x6000-0x7FFF region."),
Test("cpp/ramg-mbc3-test.gb", rom="cpp/ramg-mbc3-test.gb", runtime=0.5,
description="Tests the width of the MBC3's RAM gate register."),
Test("cpp/sgb-ext-test.gb", rom="cpp/sgb-ext-test.gb", runtime=0.5, model=SGB, url="https://github.com/CasualPokePlayer/test-roms/tree/sgb-ext-test",
description="Tests the SGB packet protocol, doing various \"stress tests\" which cannot be passed without correctly emulating the SGB packet protocol. (See repository for passing reference)"),
Copy link
Copy Markdown
Member

@avivace avivace May 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a precise explanation on the repository nor some readme :/ Could we add (or link) to something explaining what it needs to pass?

Copy link
Copy Markdown
Contributor Author

@CasualPokePlayer CasualPokePlayer May 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can probably write-up something later. I haven't gotten to it since it's mainly a ton of different minor tests all in one.

Copy link
Copy Markdown
Member

@avivace avivace May 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CasualPokePlayer thanks! Merging it in the meantime

]
Binary file added testroms/cpp/sgb-ext-test.gb
View file
Open in desktop
Binary file not shown.
Loading