Add sgb-ext-test#88
Merged
Merged
Conversation
avivace
requested changes
May 25, 2026
| Test("cpp/ramg-mbc3-test.gb", rom="cpp/ramg-mbc3-test.gb", runtime=0.5, | ||
| description="Tests the width of the MBC3's RAM gate register."), | ||
| Test("cpp/sgb-ext-test.gb", rom="cpp/sgb-ext-test.gb", runtime=0.5, model=SGB, url="https://github.com/CasualPokePlayer/test-roms/tree/sgb-ext-test", | ||
| description="Tests the SGB packet protocol, doing various \"stress tests\" which cannot be passed without correctly emulating the SGB packet protocol. (See repository for passing reference)"), |
Member
There was a problem hiding this comment.
I don't see a precise explanation on the repository nor some readme :/ Could we add (or link) to something explaining what it needs to pass?
Contributor
Author
There was a problem hiding this comment.
I can probably write-up something later. I haven't gotten to it since it's mainly a ton of different minor tests all in one.
Member
There was a problem hiding this comment.
@CasualPokePlayer thanks! Merging it in the meantime
avivace
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #80