Skip to content

fix: close old pages before clearing map during handoff #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
km-git007 wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −0
Open

fix: close old pages before clearing map during handoff #787

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions browse/src/browser-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -867,6 +867,11 @@ export class BrowserManager {
// Swap to new browser/context before restoreState (it uses this.context)
const oldBrowser = this.browser;

// Close old pages before clearing the map to release resources
for (const page of this.pages.values()) {
await page.close().catch(() => {});
}

this.context = newContext;
this.browser = newContext.browser();
this.pages.clear();
Expand Down