fix: close old pages before clearing map during handoff#787
Open
km-git007 wants to merge 1 commit intogarrytan:mainfrom
Open
fix: close old pages before clearing map during handoff#787km-git007 wants to merge 1 commit intogarrytan:mainfrom
km-git007 wants to merge 1 commit intogarrytan:mainfrom
Conversation
When handing off from headless to headed mode, old pages were removed from
the pages map without being explicitly closed. This left Playwright Page
objects dangling with their event listeners and resources intact, causing
a resource leak.
The pattern for cleanup should match closeAllPages() and recreateContext(),
which both explicitly close pages before clearing the map:
for (const page of this.pages.values()) {
await page.close().catch(() => {});
}
this.pages.clear();
This ensures Playwright resources are properly released when switching to
headed mode, preventing memory accumulation on repeated handoff/resume cycles.
Fixes resource leak in interactive handoff workflow (headless → headed mode).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When handing off from headless to headed mode, old pages were removed from the pages map without being explicitly closed. This left Playwright Page objects dangling with their event listeners and resources intact, causing a resource leak.
The pattern for cleanup should match closeAllPages() and recreateContext(), which both explicitly close pages before clearing the map:
for (const page of this.pages.values()) {
await page.close().catch(() => {});
}
this.pages.clear();
This ensures Playwright resources are properly released when switching to headed mode, preventing memory accumulation on repeated handoff/resume cycles.
Fixes resource leak in interactive handoff workflow (headless → headed mode).