chore(frontseat-api): GH-201 reword product references to neutral terms - #232
Merged
Conversation
References to specific downstream products in the OSS surface (proto comments, API READMEs, the remote-only-execution design doc) become product-neutral: "IDE integrations" and "aggregating consumers". Regenerating also catches up pre-existing codegen drift: the committed TypeScript gen still contained the removed relations/query/order_by fields and predates protoc-gen-es 2.13.0, and bytestream.connect.go lagged its source proto's header comment. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
5 tasks
joaodinissf
approved these changes
Jul 29, 2026
joaodinissf
left a comment
joaodinissf
left a comment
Collaborator
There was a problem hiding this comment.
Generated code verified rather than assumed: the agent decoded both FileDescriptorProtos (buf-built at head vs the rawDesc extracted from the committed .pb.go) and they correspond exactly to the proto edit — no hand-editing.
Three product references survive the sweep, going into a follow-up PR rather than blocking this one:
libs/frontseat-api-ts/src/index.ts:3,12-13— the same two sentences reworded in the sibling README, andpackage.jsondeclaresfiles: ["dist", "src"], so this one ships in the npm tarball.libs/frontseat-daemon/internal/transport/catalog_connect_adapter.go:88—(IDEs, portals)on the doc comment fortaskSchemaVersion, the constant populating the veryschema_versionfield whose proto comment this PR rewrote.libs/frontseat-api-ts/buf.gen.yaml:1-2— repo-visible only.
This review was published with assistance from Claude.
This was referenced Jul 29, 2026
joaodinissf
added a commit
that referenced
this pull request
Aug 1, 2026
…uct references GH-232 neutralised the downstream-product names across the proto comments, apis/README.md, libs/frontseat-api-ts/README.md and the remote-only-execution design doc, but three sites kept the old wording. src/index.ts matters most: package.json lists "src" in files, so that header ships verbatim in the published @frontseat/api tarball — the sibling README it paraphrases was already reworded. buf.gen.yaml is repo-visible only. The taskSchemaVersion comment sits on the constant that populates ListTasksResponse.schema_version, the very field whose proto comment GH-232 rewrote. Comments only; no generated code and no behaviour change. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #228 (auto-closed by the history-rewrite force-push). #229 is stacked on this branch.
Second checklist item of #201: references to specific downstream products in the OSS surface are reworded to product-neutral terms ("IDE integrations", "aggregating consumers") in the proto comments,
apis/README.md,libs/frontseat-api-ts/README.md, and the remote-only-execution design doc, with Go/TS code regenerated.The regen also catches up pre-existing drift in committed generated code:
relations/query/order_byfields and was produced by an older protoc-gen-es (2.12.1 → 2.13.0, both within the declared^2.2.0range)bytestream.connect.golagged its source proto's header comment🤖 Generated with Claude Code