chore(frontseat-api-ts,frontseat-daemon): GH-201 reword the last product references - #268
Open
joaodinissf wants to merge 1 commit into
Open
chore(frontseat-api-ts,frontseat-daemon): GH-201 reword the last product references#268joaodinissf wants to merge 1 commit into
joaodinissf wants to merge 1 commit into
Conversation
…uct references GH-232 neutralised the downstream-product names across the proto comments, apis/README.md, libs/frontseat-api-ts/README.md and the remote-only-execution design doc, but three sites kept the old wording. src/index.ts matters most: package.json lists "src" in files, so that header ships verbatim in the published @frontseat/api tarball — the sibling README it paraphrases was already reworded. buf.gen.yaml is repo-visible only. The taskSchemaVersion comment sits on the constant that populates ListTasksResponse.schema_version, the very field whose proto comment GH-232 rewrote. Comments only; no generated code and no behaviour change. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
joaodinissf
force-pushed
the
chore/201-reword-remaining-product-references
branch
from
August 1, 2026 20:24
44397a9 to
dc2b406
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#232 neutralised the downstream-product names across the proto comments,
apis/README.md,libs/frontseat-api-ts/README.mdand the remote-only-executiondesign doc, but three sites kept the old wording.
libs/frontseat-api-ts/src/index.tsIDE, Backstage portal frontend and backend/the portal builds-backendIDE integrations, aggregating backends/an aggregating backendlibs/frontseat-api-ts/buf.gen.yamlIDE, portal frontend and backendIDE integrations, aggregating backendslibs/frontseat-daemon/.../catalog_connect_adapter.goexternal consumers (IDEs, portals)external consumers (IDE integrations, aggregating consumers)src/index.tsis the one that matters:package.jsonlists"src"infiles, sothat header ships verbatim in the published
@frontseat/apitarball — while thesibling README it paraphrases was already reworded.
buf.gen.yamlis repo-visibleonly. The
taskSchemaVersioncomment sits on the constant that populatesListTasksResponse.schema_version, the very field whose proto comment #232 rewrote.Comments only — no generated code, no behaviour change. Wording follows #232's
("IDE integrations", "aggregating consumers/backends").
Deliberately left alone:
Central Portalin the Maven deploy extension (that isMaven Central's product name),
apis/third_party/(vendored upstream), anddocs/backstage-ide.md(a design note that is genuinely about Backstage).Relates to #201
This pull request was published with assistance from Claude.