Repository navigation
nix2cf: goal-file schema_version 4 (supervisor input, nixos passthrough host, version pin check) (S4) - #2
Conversation
… passthrough host, version CI check)
supervisor is a required host input (CLI --supervisor, no default) written into
device-trust.entries.supervisor; a disagreeing supplied document is refused. A
nixos host refuses any selected service and renders supervision
deliberately-unmanaged (projects to {"vars":{}}); nixos is refused below v4.
Goldens regenerated, nixos golden added, tendcf cross-file checks run in the
tests, scripts/check_schema_version.py runs in CI before the tests.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: 4d92017e-fa17-4e16-ae56-dcf9475d7a36) |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
render_goal_file re-checks host_errors and supervisor_refusals; SUPPORTED_SCHEMA_VERSIONS derives the current version; v3-with-schemas test; nixos golden pinned to tendcf's passthrough fixture; DESIGN.md Termux wording; --platform required, android dropped from choices; per-row expected messages. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: 797867fd-578d-485c-8d90-56ddac65e490) |
Slice S4 of tendcf docs/architecture/schema-v4-reconciliation-2026-10-31.md §6.2 (https://github.com/frdminc/tendcf/blob/master/docs/architecture/schema-v4-reconciliation-2026-10-31.md). nix2cf rendered schema_version 1; tendcf master is at 4 (CI red since tendcf's v2).
Local (TENDCF_DIR=tendcf master): 43 passed, 1 skipped (nix-instantiate absent). 7 mutants killed. nixos host projects to exactly {"vars":{}} via tendcf's projector.
Author: Claude Sonnet 5.5 high (bigteam slice); lead: Opus 5.5 high.
Review: Fable 5.1 high (
acp-dispatch claude --model fable --kind frontier, read-only); astra short (codex below the 60% estimate floor). Verdict: approve with changes, all Low. Fixed in 0d79883: F1 render_goal_file re-checks host errors itself; F2 supported versions derived; F3 v3-with-schema test; F4 nixos golden byte-equal to tendcf deploy/linux/passthrough/goal-file.json; F5 DESIGN wording; F6 (lead) --platform required, android not offered; F7 per-row messages. Local: 47 passed, 1 skipped.Note
Medium Risk
Breaking CLI and goal-file contract changes (schema v4, new required flags) affect what consent binds to; behavior is heavily tested and pinned to tendcf's schema const in CI.
Overview
Aligns nix2cf with tendcf goal-file schema v4:
GOAL_FILE_SCHEMA_VERSIONis 4, goldens pick updevice-trust.entries.supervisorand the new version, and CI runsscripts/check_schema_version.pyso a tendcf schema bump fails with one clear message instead of many test diffs.CLI / host input:
buildfilenow requires--platform(macos|linux;androidremoved) and--supervisor(launchd|systemd|runit|nixos, no defaults). The compiler writes the supervisor into the goal file and refuses a--device-trustfile whose existingsupervisorentry disagrees. Platform↔supervisor pairings are enforced (e.g. macos→launchd, linux→systemd|runit|nixos).Compile behavior: Only launchd still renders units; systemd/runit hosts with selected services are refused until the step‑6 renderer exists. nixos hosts with no selected services emit
supervision: {"coverage": "deliberately-unmanaged"}(projector →{"vars":{}}); any selected service is refused. The library can render schema v3 viacompile_host(..., schema_version=3)(drops the supervisor entry); nixos is refused below v4.Tests add tendcf cross-file lint, nixos golden/oracle checks, and broad supervisor/schema-version coverage; docs and the example
device-trust.jsonare updated to match.Reviewed by Cursor Bugbot for commit 0d79883. Bugbot is set up for automated code reviews on this repo. Configure here.