Repository navigation
Conversation
…ests, docs; keep 3 and 4 renderable
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: 6e567500-5ba5-4d02-858f-f538b29a3800) |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…sed at v5); select dev.mise.* writer by prefix (P3)
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: fb140f51-d68d-439c-8554-df30db782090) |
…it hosts, v5 output schema-validated (astra 6.1)
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: f4d0da46-0960-405d-9de0-9d5ce37443de) |
S3 of tendcf schema v5 (spec
docs/architecture/schema-v5-dpkg-reconciliation-2026-11-02.md§4 item 11; tendcf PR frdminc/tendcf#37, master 03224e42). Same shape as the v4 bump (PR #2).Change
GOAL_FILE_SCHEMA_VERSION4 -> 5;scripts/check_schema_version.pyagainst tendcf master:ok: both are 5.SUPPORTED_SCHEMA_VERSIONS = (3, 4, GOAL_FILE_SCHEMA_VERSION): v4 added, 3 kept. For every host nix2cf renders, the v4 file is the v5 file barschema_version(new testtest_schema_v4_differs_from_current_only_in_the_version); the spec names no downgrade path and no device holds a baseline (spec §4 item 1), so keeping both is a conservative no-op, not a claim of a shape a v5 validator accepts (older files are never schema-validated). Dropping 3/4 is a one-line change if the lead prefers.nixos-getstill equals tendcf'sdeploy/linux/passthrough/goal-file.jsonbyte for byte.== 4asserts now 5; unsupported-version test uses current+1; newtest_dpkg_writer_is_refused_at_v5.docs/DESIGN.md: version text, older-version row, new rows for the v5 key grammar and tombstones.v5 delta impact: no renderer change
cfengine/mise/nix-darwin/apple(fromlaunchd-writers.yml); neverdpkg, nevertendcf-install. Adpkgwriter in the Site Model is refused (writers schema and goal-file schema).com.djbclark.*,org.tendcf.*,dev.mise.*,org.nixos.*,com.apple.*), all matching both the new base regex and the launchd/runit v4 regex. Zero rejected.supervisiondomain.Verification
uv run pytestwith TENDCF_DIR=tendcf master: 49 passed, 1 skipped (nix-instantiate absent).check_goal_file_cross_filefindings none; every unit-writer key matches the v5 regex; no tombstones.Review
Standing rule: this PR needs one cross-model frontier review (astra/Fable/Argon) before merge; not yet done. Not merged.
Note
Low Risk
Version constant, docs, goldens, and tests only; compiler output shape is unchanged for current fixtures aside from schema_version, with v5 validation catching retired writers like dpkg.
Overview
Aligns nix2cf with tendcf goal-file schema v5 by bumping
GOAL_FILE_SCHEMA_VERSIONfrom 4 to 5 and extendingSUPPORTED_SCHEMA_VERSIONSto (3, 4, 5) so the library can still emit older shapes. The CLI and default compile path now stamp schema_version 5; three golden fixtures are regenerated with only that field changed.Documentation in README and
docs/DESIGN.mdis updated for v5: older-version rendering semantics (v4 vs v5 byte identity for current Site Model inputs, with an explicit caveat that historical v4dpkgunit-writer claims are not v5-valid), v5 unit-writer key rules, and tombstone limitations.Tests assert against
GOAL_FILE_SCHEMA_VERSION, add parametrized coverage that v4 and v5 output differ only by version for launchd/nixos/systemd/runit host shapes, and addtest_dpkg_writer_renders_at_v4_but_is_refused_at_v5for the retired writer. No change to the launchd merge/render logic—v5 compliance for normal sites comes from existing output plus tendcf schema validation.Reviewed by Cursor Bugbot for commit 6a10632. Bugbot is set up for automated code reviews on this repo. Configure here.
Review: astra (gpt-6-astra high, read-only): sound with changes. All applied.
dpkgwriter renders at v4 and is rejected at v5. Comments and DESIGN.md are narrowed to inputs valid under the current contract. The dpkg test now asserts that the v4 render keeps the claim and that schema-validated v5 compilation refuses it.CI on 6a10632: test pass. Suite: 52 passed, 1 skipped (no nix-instantiate).