fix: manually running custom homepage fields patch#303
Merged
rohitwaghchaure merged 3 commits intoMay 13, 2025
Conversation
before this the patch was being skipped as while installing webshop the "Website Items" table would be created and thus the install script skipped all patches. but this patch is mandatory to be executed as without this patch the homepage overrides made for webshop misbehave.
create_website_items handles the check
re: fix patch name
Contributor
|
@Mergifyio backport version-15 |
Contributor
✅ Backports have been createdDetails
|
mergify Bot
pushed a commit
that referenced
this pull request
May 13, 2025
* fix: manually running custom homepage fields patch before this the patch was being skipped as while installing webshop the "Website Items" table would be created and thus the install script skipped all patches. but this patch is mandatory to be executed as without this patch the homepage overrides made for webshop misbehave. * fix: remove condition which checked for "Website Item" table create_website_items handles the check * fix: remove condition which checked for "Website Item" table re: fix patch name (cherry picked from commit 06b6d06)
|
@stravo1 I am not sure how to test because Homepage has been removed from the frappe develop branch, which I believe makes the PR into frappe develop invalid, correct? Wouldn't it need to go into version-15-hotfix? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
before this the patch was being skipped as while installing webshop the "Website Items" table would be created and thus the
install.pyscript skipped all patches. but this patch is mandatory as without this patch the homepage overrides made for webshop misbehave: #57