fix: installation failure#306
Merged
rohitwaghchaure merged 5 commits intoMay 18, 2025
Merged
Conversation
before this the patch was being skipped as while installing webshop the "Website Items" table would be created and thus the install script skipped all patches. but this patch is mandatory to be executed as without this patch the homepage overrides made for webshop misbehave.
create_website_items handles the check
re: fix patch name
ordering of patch execution also changed as one of the patches (` make_homepage_products_website_items` ) depended on another patch being executed before it ( `add_homepage_field` )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses #305
after #303 the check was removed from
install.py -> run_patches(), all the patches were being executed and in a few patches the old "E Commerce Settings" doctype was being used without checking whether it existed or not which in turn caused the error.also the ordering of the execution of patches had to be changed as one of the patches (
make_homepage_products_website_items) depended on another patch being executed before it (add_homepage_field)