Skip to content

test(core): backup uniquify contract (-2/-3 suffix, never clobber) #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fotedev merged 1 commit into from
Oct 30, 2026
Merged

test(core): backup uniquify contract (-2/-3 suffix, never clobber) #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion tests/python/test_ghost_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -586,16 +586,30 @@ def test_label_may_carry_a_subdirectory(self):
self.assertTrue(os.path.isfile(
os.path.join(self.backup_root, "sub", "state.vscdb")))

def test_existing_destination_is_clobbered(self):
def test_existing_destination_is_uniquified_not_clobbered(self):
# 4f308f8 changed the contract: an existing same-label destination is
# NEVER overwritten (that destroyed pristine pre-run copies); the new
# backup uniquifies with a -2 suffix instead. The old copy must
# survive untouched and the report must point at the unique path.
dst = os.path.join(self.backup_root, "state.vscdb")
os.makedirs(self.backup_root, exist_ok=True)
with open(dst, "wb") as f:
f.write(b"stale-backup-bytes")
r = backup.backup_to_timestamped_dir(
self.src_file, self.backup_root, "state.vscdb")
self.assertTrue(r["ok"], r)
self.assertEqual(r["destination"], dst + "-2")
with open(dst, "rb") as f:
self.assertEqual(f.read(), b"stale-backup-bytes")
with open(dst + "-2", "rb") as f:
self.assertEqual(f.read(), b"sqlite-bytes" * 64)
# A third run keeps walking the suffix chain (-3), never touching -1.
r2 = backup.backup_to_timestamped_dir(
self.src_file, self.backup_root, "state.vscdb")
self.assertTrue(r2["ok"], r2)
self.assertEqual(r2["destination"], dst + "-3")
with open(dst, "rb") as f:
self.assertEqual(f.read(), b"stale-backup-bytes")

def test_transient_lock_retries_then_succeeds(self):
calls = []
Expand Down
Loading