Skip to content

test(core): backup uniquify contract (-2/-3 suffix, never clobber) - #18

Merged
fotedev merged 1 commit into
mainfrom
test/core-backup-uniquify
Oct 30, 2026
Merged

fotedev merged 1 commit into
mainfrom
test/core-backup-uniquify

Conversation

@fotedev

@fotedev fotedev commented Oct 30, 2026

Copy link
Copy Markdown
Owner
  • Aligns tests/python/test_ghost_core.py with the 4f308f8 contract change: an existing same-label backup destination is NEVER overwritten — it uniquifies with a -2 suffix (and a third run walks to -3), the stale copy survives untouched byte-for-byte, and the report points at the unique path.

@coderabbitai

coderabbitai Bot commented Oct 30, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5e086fb7-bfa4-4857-8b04-a81fc2fba24d
Commits

Reviewing files that changed from the base of the PR and between ebb98e9 and 4e8ea67.

Files selected for processing: 1
  • tests/python/test_ghost_core.py
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@fotedev

fotedev commented Oct 30, 2026

Copy link
Copy Markdown
Owner Author

Local review: the python suite could not be executed from the agent shell (unittest import resolution limitation, no code change implied). The change is test-only and matches the 4f308f8 contract. Proceeding with merge per owner instruction.

@fotedev
fotedev merged commit f49b0ac into main Oct 30, 2026
4 checks passed
@fotedev
fotedev deleted the test/core-backup-uniquify branch October 30, 2026 02:55
@fotedev fotedev mentioned this pull request Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant