Skip to content

fix(image): process png images through magick if available #2952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
madmaxieee wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −1
Open

fix(image): process png images through magick if available #2952

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion lua/snacks/image/convert.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,13 @@ local proc_queue = {} ---@type snacks.spawn.Proc[]
local proc_running = 0 ---@type number
local MAX_PROCS = 3

local function has_magick()
if have.magick == nil then
have.magick = vim.fn.executable("magick") == 1 or (not Snacks.util.is_win and vim.fn.executable("convert") == 1)
end
return have.magick
end

---@param proc? snacks.spawn.Proc
local function schedule(proc)
if proc then
Expand Down Expand Up @@ -329,7 +336,7 @@ function Convert:resolve()
self:_resolve("url")
self:_resolve("identify")
end
while self:ft() ~= "png" do
while self:ft() ~= "png" or (#self.steps == 0 and has_magick()) do
local ft = self:ft()
local target = commands[ft] and ft or "convert"
if self:_resolve(target) then
Expand Down
Loading