fix(image): process png images through magick if available - #2952
Open
madmaxieee wants to merge 1 commit into
Open
fix(image): process png images through magick if available#2952madmaxieee wants to merge 1 commit into
madmaxieee wants to merge 1 commit into
Conversation
Ensure that image files are downscaled with ImageMagick when magick is available, even if the file extension is already png.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ensure that image files are downscaled with ImageMagick when magick is available, even if the file extension is already png. Rendering a full high res PNG screenshot without downscaling would often get to over 50MB for the raw RGBA data. This may cause lag on the terminal emulator. This new behavior is also less surprising by enforcing the "default" convert command on png, which is documented as "default for raster images".
Related Issue(s)
Screenshots