Skip to content

UILD-859: Correct missing useEffect dependencies and fix test suite consistency issues - #439

Merged
zepheiryan merged 1 commit into
masterfrom
UILD-859
Aug 20, 2026
Merged

UILD-859: Correct missing useEffect dependencies and fix test suite consistency issues#439
zepheiryan merged 1 commit into
masterfrom
UILD-859

Conversation

@zepheiryan

Copy link
Copy Markdown
Contributor

Purpose

ManageProfileSettings.test fails in CI due to a number of test suite issues. The way it was written masked failures when run locally, including missing useEffect dependencies. Address these so the suite is stable.

Approach

  • Correct missing useEffect dependencies
  • Correct responsiveness tests to check for presence of CSS class, not element visibility
  • Use async and await with waitFor
  • Avoid stale references to DOM objects when clicking in some tests

Refs

https://folio-org.atlassian.net/browse/UILD-859

@zepheiryan
zepheiryan requested a review from a team as a code owner August 18, 2026 19:54
@github-actions

Copy link
Copy Markdown

Jest Unit Test Results

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 127ce2f. ± Comparison against base commit 22a7524.

@sonarqubecloud

Copy link
Copy Markdown

@zepheiryan
zepheiryan merged commit db3f230 into master Aug 20, 2026
16 checks passed
@zepheiryan
zepheiryan deleted the UILD-859 branch August 20, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants