UILD-842: Move settings application to within click handler - #440
Merged
Conversation
…f a generic useEffect, avoid side effects of running it on load before stores are fully caught up
|
BogdanDenis
approved these changes
Aug 21, 2026
Dmytro-Melnyshyn
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix problems on editor load where authority value labels are not displayed at all.
Approach
Settings application was previously implemented through
useEffect, which ended up causing an unwanted run on page load, before all stores were fully settled, that caused complex values to be blanked on re-render since they hadn't yet been set in the user values service.Move settings application directly to the site where it's changed by the user instead, avoiding the on load problems.
Also remove an unnecessary
key.Refs
https://folio-org.atlassian.net/browse/UILD-842
Screenshots
Creator's name now renders again correctly:
