MODEXPW-643 - Populate exportTransmissionMethod on ExportHistory for order exports - #750
Open
markusweigelt wants to merge 9 commits into
Open
MODEXPW-643 - Populate exportTransmissionMethod on ExportHistory for order exports#750markusweigelt wants to merge 9 commits into
markusweigelt wants to merge 9 commits into
Conversation
Stamp how an EDIFACT/CSV export was actually delivered (FTP, Email, or File download) onto ExportHistory, set only when the matching delivery step succeeds so a failed or skipped transmission records no method.
Temporary development pin so the branch builds against the unmerged schema changes. Must be reverted to the folio-org URL before merge.
SerhiiNosko
approved these changes
Aug 11, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MODEXPW-643 - Populate exportTransmissionMethod on ExportHistory for order exports
Purpose
ExportHistoryrecords that an EDIFACT/CSV order export happened, but not how the file actually reached the vendor. The export config'stransmissionMethodonly states what was requested.This fills in the
exportTransmissionMethodfield added to theExportHistoryschema, so theedi-export-history.createevent carries the channel that actually succeeded. Later mod-orders-storage MODORDSTOR-526 consumes it and stampspoLine.lastExport.transmissionMethod, which makes PO lines filterable and sortable by how they were last transmitted.The value is set only when the matching delivery step succeeds, so a failed or skipped transmission records no method at all rather than a misleading one.
Approach
acqExportTransmissionMethodjob-context key (JobParameterNames) and asetJobExecutionContext(StepExecution, key, value)overload inExecutionContextUtilsthat writes to the job-level execution context, so the value survives from the delivery step to the later export-history step.SaveToFileStorageTasklet→FTPSendToEmailTasklet→EmailSaveToMinioTasklet→File downloadSaveToMinioTaskletis gated on the config actually requestingFILE_DOWNLOAD. The MinIO upload runs for every job regardless of channel, so an ungated stamp would relabel FTP and Email jobs as file downloads.ExportHistoryTaskletreads the key and maps it ontoExportHistory.ExportTransmissionMethodEnum, leaving the fieldnullwhen no delivery step recorded one.folio-export-commonsubmodule for theexportTransmissionMethodschema field.Depends on
folio-org/folio-export-common#113