MODORDSTOR-526 - Support export transmission method on purchase order lines - #653
Open
markusweigelt wants to merge 3 commits into
Open
MODORDSTOR-526 - Support export transmission method on purchase order lines#653markusweigelt wants to merge 3 commits into
markusweigelt wants to merge 3 commits into
Conversation
Copy the transmission method from the export history event onto the order line as lastExport.transmissionMethod and index it, so lines can be filtered and sorted by how they were last transmitted. An unrecognised value clears the field instead of failing the event, leaving lastEDIExportDate intact.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MODORDSTOR-526 - Support export transmission method on purchase order lines
Purpose
mod-data-export-worker now stamps
exportTransmissionMethodonto theExportHistoryKafka event, recording how an EDIFACT/CSV order export was actually delivered — FTP, Email, or File download — and only after that delivery succeeded (see MODEXPW-643 - Populate transmission method on ExportHistory in EDIFACT/CSV order export).Until now the only trace of an export on a PO line was
lastEDIExportDate: when a line was exported, never how. This change consumes the new value and persists it on the order line, so lines can be filtered and sorted by their last transmission method.Approach
EdiExportOrdersHistoryAsyncRecordHandlernow copies the event's transmission method onto each exported line aslastExport.transmissionMethod, alongside the existinglastEDIExportDateupdate.schema.json— a plain btree index on the dotted pathlastExport.transmissionMethod(caseSensitive: true,removeAccents: false), which backs both CQL filtering andsortby.orders-storage.po-lines13.0 → 13.1 andorders-storage.export-history1.0 → 1.1.last_export.json,poLine.lastExportandexportHistory.exportTransmissionMethod.lastEDIExportDateis deliberately left flat and untouched.Depends on