Skip to content

fetch_package#165

Merged
JaeseungYeom merged 6 commits into
flux-framework:mainfrom
JaeseungYeom:fetch_package
Jun 2, 2026
Merged

fetch_package#165
JaeseungYeom merged 6 commits into
flux-framework:mainfrom
JaeseungYeom:fetch_package

Conversation

@JaeseungYeom

@JaeseungYeom JaeseungYeom commented May 25, 2026

Copy link
Copy Markdown
Contributor

This PR is exclusively on cmake

  • Replacing FindCppLogger and FindGotcha, which are cmake FetchContent wrappers with fetch_package utility function.
  • Fixed outdated import config input files
  • Changed the namespace from DYAD:: to dyad::

Currently waiting for the PRs to be merged at gotcha and cpp-logger repos.

Then, I will replace git url and tag used in fetch_package to the latest in each repo.

@JaeseungYeom JaeseungYeom requested a review from wangvsa May 25, 2026 07:40
@JaeseungYeom JaeseungYeom self-assigned this May 25, 2026
@JaeseungYeom JaeseungYeom added bug Something isn't working enhancement New feature or request labels May 25, 2026
@JaeseungYeom JaeseungYeom marked this pull request as draft May 25, 2026 07:41
@JaeseungYeom JaeseungYeom mentioned this pull request May 26, 2026
@JaeseungYeom JaeseungYeom marked this pull request as ready for review May 28, 2026 03:46
@JaeseungYeom

Copy link
Copy Markdown
Contributor Author

I am merging this as is with dependency repo addresses redirected to my fork rather than waiting for the fixes to be applied at the source repos. I will change the fork addresses to the original addresses later.

@JaeseungYeom JaeseungYeom merged commit 3ee1d48 into flux-framework:main Jun 2, 2026
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant