Skip to content

Catch2 upgrade#166

Merged
JaeseungYeom merged 7 commits into
flux-framework:mainfrom
JaeseungYeom:catch2_upgrade
Jun 2, 2026
Merged

Catch2 upgrade#166
JaeseungYeom merged 7 commits into
flux-framework:mainfrom
JaeseungYeom:catch2_upgrade

Conversation

@JaeseungYeom

Copy link
Copy Markdown
Contributor

This PR fixes outdated unit test relying on Catch2 v2. It depends on PR #165

  • Add FetchContent-based Catch2 dependency management.
  • Fix outdated unit test relying on Catch2 v2 for new Catch2 v3.
  • Add missing c++ guard in dyad_client_int.h to avoid linking error

@JaeseungYeom JaeseungYeom requested a review from wangvsa May 26, 2026 23:06
@JaeseungYeom JaeseungYeom self-assigned this May 26, 2026
@JaeseungYeom JaeseungYeom added bug Something isn't working enhancement New feature or request labels May 26, 2026
@JaeseungYeom JaeseungYeom marked this pull request as draft May 27, 2026 03:41
@JaeseungYeom JaeseungYeom marked this pull request as ready for review May 28, 2026 03:46
@JaeseungYeom

Copy link
Copy Markdown
Contributor Author

Merging this to allow unit test to build

@JaeseungYeom JaeseungYeom merged commit f6994bd into flux-framework:main Jun 2, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant