Repository navigation
app: Undo names whose step it takes, and the bubble after it has a Redo - #495
Merged
Merged
Conversation
When the step an undo would take was made by someone else, the Edit menu reads "Undo Claude's Draw" (and Redo likewise), and pressing it says "Undid Claude's Draw" on the document with a Redo that puts it back. The person's own steps read "Undo" as always. `Editor.stepToTake` finds the step and its author for the menu, the bubble and `fizzy.undo` alike. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of fizzyedit/plans#14 —
plans/SHARED_HISTORY_PLAN.mdstep 5b (after 5a, #487).What changes
Cmd-Z stays linear: it takes the last change, whoever made it. It now says whose that is.
historyLineonly once someone besides the person has acted on the document (Host.step_authors).ActivityFeed.pushAction. A feed item may carry a button. It alone takes clicks, on a small layer of its own, so the rest of the feed still never covers the work. An item with a button stays 6 s instead of 2.4 s.drawreturns the tag of the button pressed.Editor.stepToTakefinds the step an undo or redo would take, where it leaves the line, and its author. It is shared by the menu title, the bubble andfizzy.undo'sexpect(which app: fizzy.undo and fizzy.redo take a path and the step expected #487 had inline).Muting the run's own "Undo" reuses
Host.activity_muted(the demo-seek flag) for the duration of that one command. It is put back before the feed draws, and the code says so.SDK impact
test-sdk-versionpasses).Verified
headless: the whole editor comes up…): an author labelled "Claude" writes into the document in front.stepToTakenames Claude.editor.undo()(Cmd-Z's path) restores the text, and the pane's last feed item reads "Undid Claude's …" with a Redo tagged with that step.claude-codewrote into an opennote.txt, then Cmd-Z was pressed through the input tape.text.read: 3 lines again).check-fmt,zig build test(574/575, 1 skipped),zig build test-integration(53/53 steps),check-web,test-sdk-version.🤖 Generated with Claude Code