Repository navigation
history: every step is reported, so fizzy knows who made it - #57
Merged
Merged
Conversation
pixi called `Host.recordStep` only while something recorded the sprite, so fizzy never kept who made a pixi step: undo couldn't name an agent's draw, and `fizzy.undo` answered "the person" for it. Every step is now reported, with the step on top (`Step.top`); its effect is still encoded only while recording. Text already works this way. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Keeps main's `motionOf` and its position-keyed, timed encode, and this branch's report of every step with the step on top. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of fizzyedit/plans#14 —
plans/SHARED_HISTORY_PLAN.mdstep 3, pixi's half, which #49 left short: "text and pixi report every step".What changes
History.recordcalledHost.recordSteponly while the sprite was being recorded. So fizzy never kept who made a pixi step (Host.stepAuthorworks from the steps owners report):fizzy.undoanswered.by = "the person"for an agent's draw.Now every step is reported, as text's are:
added,undoneandredonecarry their id and the step on top after them (Step.top, fromHistory.top()).restartedis reported whether or not anything records.Unchanged: while recording, a change pixi cannot encode (a layer, an animation) still reports
restarted, so the track starts over rather than drifting. That also clears the authors fizzy kept for the sprite, as any restart does.Verified
On macOS, in a sandbox fizzy built from
main(past 0.2.29; built with--fork): an MCP client namedclaude-codedrew a rect withpixi.draw, then calledfizzy.undo .{ .path }, which answered.by = "Claude". Before this change the same sequence answered.by = "the person".zig build,zig fmt --check.🤖 Generated with Claude Code