-
Notifications
You must be signed in to change notification settings - Fork 303
Carplay Homescreen and Now Playing Updates #1713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: redesign
Are you sure you want to change the base?
Changes from all commits
1947225
2b2818f
09d3c41
9dd05ca
916f367
247319b
e84bb09
cfddf2e
17aa8ee
5287a1f
d79c1a8
7b7dbcb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -446,6 +446,13 @@ Future<void> _setupPlaybackServices() async { | |
| // notificationColor: TODO use the theme color for older versions of Android, | ||
| // We will handle preloading artwork ourselves | ||
| preloadArtwork: false, | ||
| // Keep iOS now playing info + remote command handlers registered when | ||
| // the service stops, so Finamp stays the system's resume candidate for | ||
| // CarPlay/Bluetooth reconnects instead of losing now-playing status to | ||
| // whichever app had it before. Requires the audio_service fork | ||
| // overrides in pubspec.yaml (the flag spans audio_service and | ||
| // audio_service_platform_interface). | ||
| iosKeepNowPlayingOnStop: true, | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this actually needed/desirable? As far as I can tell, the stopService command this is intercepting only occurs when we actually call stop() against just_audio, and we only do that on explicit user request. I would imagine if the user has stopped and cleared the queue, they don't actually want us to be taking the now-playing status like this. Or is there something more complex going on?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was because I kept finding Finamp would lose the now playing/last playing status to other apps which are grabby such as Apple's Podcast app. It appears that audio_service calls |
||
| androidBrowsableRootExtras: <String, dynamic>{ | ||
| // support showing search button on Android Auto as well as alternative search results on the player screen after voice search | ||
| "android.media.browse.SEARCH_SUPPORTED": true, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know anything about the UIScene migration? The carplay code seems to have left us in a strange, partially migrated state, and I'd like to try to bring us closer to the flutter guidelines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fairly weak on it. I've had a look now, and I see I did make it a bit worse last time. I can do a follow up commit later to combine the plists and get this cleaned up. Keen to not expand this MR too much more - I'll make a ticket for it.