Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
wschurman
changed the title
wschurman
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #486 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 110 110
Lines 16394 16394
Branches 900 1475 +575
==========================================
Hits 16394 16394
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wschurman
changed the base branch from
wschurman/02-27-fix_fix_some_security_issues
to
graphite-base/486
wschurman
force-pushed
the
wschurman/02-27-fix_escape_all_parts_of_the_local_memory_cacher_cache_key
branch
from
9734940 to
5608f55
Compare
wschurman
force-pushed
the
graphite-base/486
branch
from
deb3741 to
e263bd2
Compare
wschurman
force-pushed
the
wschurman/02-27-fix_escape_all_parts_of_the_local_memory_cacher_cache_key
branch
2 times, most recently
from
2093ef8 to
1d447e9
Compare
wschurman
force-pushed
the
wschurman/02-27-fix_escape_all_parts_of_the_local_memory_cacher_cache_key
branch
from
1d447e9 to
37f2c00
Compare
ide
approved these changes
Mar 2, 2026
wschurman
deleted the
wschurman/02-27-fix_escape_all_parts_of_the_local_memory_cacher_cache_key
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
One more review suggestion from claude. This fixes an incorrect encoding of the cache keys where if a key portion included a
:(delimiter) it could potentially conflict with another key (though admittedly very unlikely). This happened because we were erroneously suggesting use ofreplaceinstead ofreplaceAll.Note that this lives in the application code where companion provider is created, so applications will need to fix independently of this upgrade. This just fixes the suggestions.
How
The fix is to use
replaceAll.Test Plan
Run new test.