fix: fix some security review suggestions#485
Merged
Conversation
This was referenced Feb 27, 2026
Merged
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #485 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 110 110
Lines 16365 16394 +29
Branches 884 900 +16
=========================================
+ Hits 16365 16394 +29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ebd68b8 to
324a609
Compare
37e8024 to
ef18615
Compare
324a609 to
1e06471
Compare
ide
reviewed
Feb 27, 2026
1e06471 to
1594f42
Compare
ef18615 to
459a5ff
Compare
1594f42 to
deb3741
Compare
quinlanj
approved these changes
Feb 28, 2026
ide
approved these changes
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why
Had claude do a security review of entity-database-adapter-knex.
How
The items it noticed were:
orderBySpecification.orderis type safe but could be overridden via anany-casted value, which could result in an injection since it was directly inserted into the knexorderByRawmethod. The fix is to do a runtime check for value equal to the enum.like/iLike/etc since they should only be usable for string-like fields.jsonContains, need to constrain types and do a runtime validity check to ensure value is JSON-serializable.Test Plan
Run new tests.