Reject instead of ignore incompatible gas limit bids#5428
Closed
nflaig wants to merge 1 commit into
Closed
Conversation
Contributor
|
I'm worried about rejecting messages that can cause peering issues. We don't check equivocations on proposer preferences. A peer may be honestly forwarding a message and be rejected and isolated by another peer that got a different proposer preference, so dishonest proposers equivocating on proposer preferences could cause a network split. Perhaps we should not reject any message based on proposer preferences. |
Member
Author
|
closing in favor of #5429, my concern was mostly about consistency between gas limit and fee recipient check, which 5429 also resolves and #5428 (comment) makes sense to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
per #5236 (comment)