Use a neutral placeholder name in fixtures and comments - #33
Merged
Merged
Conversation
Every sample USER_NAME, memory title and worked example in the tests and
in two source comments was the author's own name. Nothing depended on it —
it is a placeholder — and it reads oddly in a project people fork and run
as themselves. `.env.example` already suggests `Tony`, so the fixtures now
match it.
Purely cosmetic: no behaviour, no assertions and no slugs change meaning,
only the string they are demonstrated with. The possessive and slug forms
moved together, so `slugify("Tony's ...") == "tonys-..."` still tests what
it always tested.
The README's attribution is deliberately left alone.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every sample
USER_NAME, memory title and worked example in the tests — plus two source comments — used the author's own name. Nothing depends on it; it is a placeholder. It reads oddly in a project people fork and run as themselves, and.env.examplealready suggestsTony, so the fixtures now match it.Purely cosmetic. No behaviour changes, no assertion changes meaning — only the string it is demonstrated with. The possessive and slug forms moved together, so
slugify("Tony's ...") == "tonys-..."still tests exactly what it did before.The README's attribution is deliberately left alone.
11 files, 59 lines. Branched off
main, independent of #32.Testing: 2405 pass.
🤖 Generated with Claude Code