Clear the five npm advisories (lockfile only) — closes #34 - #35
Merged
Merged
Conversation
`npm audit fix` takes all five to patched releases inside the ranges
package.json already declares, so only the lockfile moves:
fflate 0.8.2 -> 0.8.3 (moderate) reported as #34
nanoid 3.3.x -> 3.3.18 (high)
picomatch 4.0.x -> 4.0.7 (high)
postcss 8.5.x -> 8.5.28 (high)
vite 6.4.1 -> 6.4.3 (high)
On #34 specifically: the advisory is real, and worth taking, but it is not
reachable here. `fflate` arrives through `@types/three`, its code does not
appear in the built bundle, and nothing in `src/` imports it or unzips
anything — JARVIS never opens an archive, let alone one it did not write.
npm rates it moderate rather than high, and the four genuinely high
advisories in the same tree were not the ones reported. Taking the bump
anyway: it is free, and an audit that is noisy is an audit nobody reads.
Not the patch the issue suggests. That one edits `node_modules/fflate/`,
which is not version controlled — the next `npm ci` discards it.
Typecheck clean, build clean, dev server serves, 2405 tests pass.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
DavidN0809
pushed a commit
to Nichols-HomeLab/jarvis
that referenced
this pull request
Oct 2, 2026
…ethanplusai#35) from renovate/python-3.14-slim into main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #34.
npm audit fixtakes all five advisories to patched releases inside the rangespackage.jsonalready declares, so only the lockfile moves — 16 insertions, 17 deletions, no dependency ranges changed:fflatenanoidpicomatchpostcssvitenpm auditnow reports 0 vulnerabilities.On #34 specifically
The advisory is real and worth taking, but it is not reachable in this project:
fflatearrives transitively through@types/threedist/assets/*.js)src/imports it, and JARVIS never opens an archive — let alone one it did not write itselfTwo details in the report don't hold up: npm rates this moderate, not high; and the four genuinely high advisories sitting in the same dependency tree weren't mentioned. Taking the bump regardless — it's free, and an audit that is noisy is an audit nobody reads.
Also not the patch the issue proposes. That diff edits
node_modules/fflate/dist/unzip.js, which isn't version controlled — the nextnpm cithrows it away.Testing
Typecheck clean,
npm run buildclean, dev server boots and serves (Vite 6.4.3), 2405 Python tests pass.Branched off
main, independent of #32 and #33.🤖 Generated with Claude Code