Redesign watch stream API#108
Merged
Merged
Conversation
belltoy
force-pushed
the
feature/watch-stream
branch
from
622c83f to
cc1284d
Compare
belltoy
force-pushed
the
feature/watch-stream
branch
from
cc1284d to
ce00c04
Compare
belltoy
force-pushed
the
feature/watch-stream
branch
from
ce00c04 to
cbb015a
Compare
belltoy
force-pushed
the
feature/watch-stream
branch
2 times, most recently
from
f381b32 to
ef34a5f
Compare
Closed
belltoy
force-pushed
the
feature/auth-interceptor
branch
from
c491fcd to
a3fbd0c
Compare
belltoy
force-pushed
the
feature/watch-stream
branch
2 times, most recently
from
501c58f to
b810cbc
Compare
The `watch` function returns a tuple `(WatchResponse, Watcher, WatchStream)`, the first element in the returned tuple is the response to the first create watch request. More importantly, the etcd `Watch` API behaves differently than other unary RPC. It doesn't send grpc-status in the trailers if something goes wrong. Instead, we must solve the result via the `WatchResponse` and its corresponding request.
belltoy
force-pushed
the
feature/watch-stream
branch
from
b810cbc to
5d2ce5d
Compare
belltoy
force-pushed
the
feature/watch-stream
branch
from
5d2ce5d to
13b2047
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #104
The
WatchClientis not a high level watcher, it is just a watch API stub. So it should be only responsible for sending requests and receiving responses. Let the high level watcher decide what to do if received an unexpected response.The new
WatchStreamis different from the old version. It represents underlying bidirectional watch stream (HTTP2 stream). So it can be used to send requests and receive responses and events.It's the user's responsibility to check the received response is a response or an event, if it is created successfully or not, or if it is a cancel response.