WIP: Re-design watch API#1
Closed
belltoy wants to merge 2 commits into
Closed
Conversation
belltoy
force-pushed
the
feature/watch-stream
branch
from
09df58c to
13d70ba
Compare
belltoy
force-pushed
the
feature/watch-stream
branch
from
13d70ba to
7e586ee
Compare
belltoy
force-pushed
the
feature/watch-stream
branch
from
7e586ee to
622c83f
Compare
Owner
Author
|
Moved to etcdv3#108 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on etcdv3#104
The
WatchClientis not a high level watcher, it is just a watch API stub. So it should be only responsible for sending requests and receiving responses. Let the high level watcher decide what to do if received an unexpected response.The new
WatchStreamis different from the old version. It represents underlying bidirectional watch stream (HTTP2 stream). So it can be used to send requests and receive responses and events.It's the user's responsibility to check the received response is a response or an event, if it is created successfully or not, or if it is a cancel response.