P4: update PAC, enable some basics by bugadani · Pull Request #5523 · esp-rs/esp-hal

bugadani · 2026-05-04T18:29:51Z

This PR enables CI, decreases default CPU clock to bootloader default, enables software interrupts and esp-rtos, fixes up linker scripts, enables some tests and examples, and clean up some of the hacks.

pmnxis · 2026-05-04T23:51:23Z

I have trouble with cfg-gating from different result between P4 and others.
For now this PR resolve it. Thx very much

github-actions · 2026-05-05T08:53:01Z

New commits in main have made this PR unmergeable. Please resolve the conflicts.

bugadani · 2026-05-05T09:57:15Z

/hil full esp32p4

github-actions · 2026-05-05T09:58:27Z

Triggered full HIL run for #5523.

Run: https://github.com/esp-rs/esp-hal/actions/runs/25369768024

Status update: HIL (full) run is still in progress or status unknown.

bugadani · 2026-05-05T09:59:43Z

Yeah that won't work until merged, will it?

Copilot

Pull request overview

Copilot reviewed 40 out of 40 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 43 out of 43 changed files in this pull request and generated 3 comments.

github-actions · 2026-05-05T10:58:21Z

New commits in main have made this PR unmergeable. Please resolve the conflicts.

Copilot

Pull request overview

Copilot reviewed 47 out of 47 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 48 out of 48 changed files in this pull request and generated 1 comment.

pmnxis

some review. Also thanks your effort on P4

pmnxis · 2026-05-05T14:49:22Z

+    cfg_if::cfg_if! {
+        if #[cfg(esp32p4)] {
+            let reg = LP_AON::regs().lp_store1();
+        } else {
+            let reg = LP_AON::regs().store1();
+        }
+    }


can we improve this with single store1 with PAC tweaking?

Copilot

Pull request overview

Copilot reviewed 53 out of 53 changed files in this pull request and generated no new comments.

Copilot

Pull request overview

Copilot reviewed 55 out of 55 changed files in this pull request and generated 3 comments.

github-actions Bot added the merge-conflict Merge conflict detected. Automatically added/removed by CI. label May 5, 2026

bugadani force-pushed the p4-pac branch from 199f799 to ba1da03 Compare May 5, 2026 09:12

bugadani marked this pull request as ready for review May 5, 2026 09:12

Copilot AI review requested due to automatic review settings May 5, 2026 09:12

github-actions Bot removed the merge-conflict Merge conflict detected. Automatically added/removed by CI. label May 5, 2026

Copilot started reviewing on behalf of bugadani May 5, 2026 09:20 View session

bugadani force-pushed the p4-pac branch 3 times, most recently from de72329 to d8616a0 Compare May 5, 2026 09:26

This comment was marked as outdated.

Sign in to view

bugadani mentioned this pull request May 5, 2026

P4: apply sw_interrupts patch esp-rs/esp-pacs#435

Merged

Copilot AI review requested due to automatic review settings May 5, 2026 09:50

Copilot started reviewing on behalf of bugadani May 5, 2026 09:50 View session

bugadani changed the title ~~P4: update PAC, enable software interrupts~~ P4: update PAC, enable some basics May 5, 2026

Copilot AI reviewed May 5, 2026

View reviewed changes

Comment thread esp-hal/ld/esp32p4/esp32p4.x Outdated

Copilot AI review requested due to automatic review settings May 5, 2026 10:20

Copilot started reviewing on behalf of bugadani May 5, 2026 10:20 View session

Copilot AI reviewed May 5, 2026

View reviewed changes

Comment thread esp-hal/src/clock/mod.rs

Comment thread esp-hal/src/clock/mod.rs

Comment thread esp-hal/src/rtc_cntl/mod.rs

github-actions Bot added the merge-conflict Merge conflict detected. Automatically added/removed by CI. label May 5, 2026

bugadani added 5 commits May 5, 2026 13:06

Update PAC, enable software interrupts

e9c2757

Enable non-driver tests

77462de

Fix linker scripts

9ccd49f

Enable LP_SLOW_CLK calibration

98deae6

Clean up

f0bf218

github-actions Bot removed the merge-conflict Merge conflict detected. Automatically added/removed by CI. label May 5, 2026

bugadani added 2 commits May 5, 2026 13:26

Use PMU from PAC

9dc3312

Also clean up MPLL setup

f2b0c5b

Copilot AI review requested due to automatic review settings May 5, 2026 11:29

Copilot started reviewing on behalf of bugadani May 5, 2026 11:30 View session

bugadani force-pushed the p4-pac branch from 8c32875 to a529a18 Compare May 5, 2026 11:34

Clean up PSRAM comments, remove unimplemented feature

c5c2d0c

bugadani force-pushed the p4-pac branch from a529a18 to c5c2d0c Compare May 5, 2026 11:35

Copilot AI reviewed May 5, 2026

View reviewed changes

Comment thread esp-hal/CHANGELOG.md Outdated

bugadani added 2 commits May 5, 2026 13:41

Changelog

fb9cfe5

Enable alloc tests

63819c1

Copilot AI review requested due to automatic review settings May 5, 2026 11:52

Copilot started reviewing on behalf of bugadani May 5, 2026 11:53 View session

Temporarily make P4 single-core

27635d1

Copilot AI reviewed May 5, 2026

View reviewed changes

Comment thread qa-test/src/bin/sw_int_timer.rs

Use common CLIC impl

8eca709

pmnxis reviewed May 5, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings May 5, 2026 15:25

Copilot started reviewing on behalf of bugadani May 5, 2026 15:26 View session

Copilot AI reviewed May 5, 2026

View reviewed changes

bugadani added 4 commits May 5, 2026 17:37

Fix direct vectoring, enable esp-rtos

c1b3b46

Enable more embassy examples

7eca922

Restore PSRAM frequency table

a3a351e

Enable esp-rtos tests

3fb896b

bugadani force-pushed the p4-pac branch from c7b785c to 3fb896b Compare May 5, 2026 15:37

bugadani added 2 commits May 5, 2026 17:43

Enable embassy benchmark

11b9fae

Enable USJ example

4ecee7e

Copilot AI review requested due to automatic review settings May 5, 2026 15:45

Copilot started reviewing on behalf of bugadani May 5, 2026 15:45 View session

Copilot AI reviewed May 5, 2026

View reviewed changes

Comment thread esp-metadata-generated/src/_generated_esp32p4.rs

Comment thread esp-metadata-generated/src/_generated_esp32p4.rs

Comment thread esp-hal/ld/esp32p4/esp32p4.x

Conversation

bugadani commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pmnxis commented May 4, 2026

Uh oh!

github-actions Bot commented May 5, 2026

Uh oh!

This comment was marked as outdated.

Uh oh!

bugadani commented May 5, 2026

Uh oh!

github-actions Bot commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bugadani commented May 5, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented May 5, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

pmnxis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pmnxis May 5, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bugadani commented May 4, 2026 •

edited

Loading

github-actions Bot commented May 5, 2026 •

edited

Loading