Skip baseline check if chip-specific baseline is not found#5519
Merged
bugadani merged 1 commit intoesp-rs:mainfrom May 4, 2026
Merged
Skip baseline check if chip-specific baseline is not found#5519bugadani merged 1 commit intoesp-rs:mainfrom
bugadani merged 1 commit intoesp-rs:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the xtask semver-check workflow to avoid failing when a chip-specific API baseline file isn’t available for a package whose public API varies by chip feature (e.g., esp-hal).
Changes:
- After attempting to download baselines, skip the semver check for a specific chip when that chip’s baseline file is still missing, logging a warning instead.
- Return
ReleaseType::Patchfor the skipped chip path so the overall semver-check flow can continue.
Comment on lines
40
to
+44
| if !baseline_path_gz.exists() { | ||
| download_baselines(&workspace, vec![package])?; | ||
| } | ||
| if package.chip_features_matter() && !baseline_path_gz.exists() { | ||
| log::warn!( |
bjoernQ
approved these changes
May 4, 2026
Contributor
|
Thanks, I will tyding #5400 to latest main branch when this is merged into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should prevent the P4 PR from failing without an esp-hal baseline.