Repository navigation
A pack owner in a Trial sees the "Trial ending soon" note (#961) - #966
Merged
Merged
Conversation
The between-Takes note read license(), which counts a pack on the Armed family as Pro, so a pack owner's Trial looked already over. It now reads planLicense(), like the Trial sheets and the days chip (#959). Record press, the limits and the after-Take offers keep license(). Assisted-by: Claude Code:claude-opus-5-5
Skeyelab
enabled auto-merge (squash)
October 27, 2026 02:46
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This was referenced Oct 27, 2026
Skeyelab
added a commit
that referenced
this pull request
Oct 27, 2026
afterShowEnded read license(), which counts a pack on the Armed family as Pro, so a pack owner whose first Show ended with that mixer Armed never got the offer. It now reads planLicense(), like the Trial note (#966). The paywall it opens already offers the upgrade to someone who bought a pack. Assisted-by: Claude Code:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #961.
The between-Takes "Trial ending soon" note now decides from
planLicense(), the plan as owned. It usedlicense(), which reports Pro when the Armed mixer's pack is owned, so a pack owner in a Trial never saw the note. Record press, the limits and the after-Take offers (afterTakeOnDevice,afterTakeStopped) still readlicense(), since they describe the Take where the pack really applied.The call moved into
RecordScreenModel.trialNote(...)so a test can reach it.Tests (AppTests/TrialNoteTests)
packOwnerInTheTrialsLastDaysSeesTheNote: red first. With the static still onlicense():✘ ... recorded an issue at TrialNoteTests.swift:29:25(no Trial note: nil). It passes after the switch.trialWithoutAPackStillSeesTheNoteandproOwnerNeverSeesTheNote: passed on their first run. They are regression guards.Full
./scripts/verify.shpassed: macOS build and AppTests, iOS Simulator build, 143s.Not checked
afterShowEndedalso readslicense(), so a pack owner whose first Show ended with that family Armed never gets the "first Show" offer. That may be intended (they recorded with Pro features). It is left for a separate issue.