Repository navigation
A pack owner gets the first-Show offer, with the upgrade (#969) - #971
Merged
Merged
Conversation
afterShowEnded read license(), which counts a pack on the Armed family as Pro, so a pack owner whose first Show ended with that mixer Armed never got the offer. It now reads planLicense(), like the Trial note (#966). The paywall it opens already offers the upgrade to someone who bought a pack. Assisted-by: Claude Code:claude-opus-5-5
Skeyelab
enabled auto-merge (squash)
October 27, 2026 03:19
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #969.
When a pack owner's first Show ends with that pack's mixer family Armed, the first-Show offer now shows, as Eric decided.
afterShowEndednow getsplanLicense(), the plan as owned, instead oflicense(), which reported Pro because of the Armed pack. The call moved intoRecordScreenModel.firstShowOffer(...), next totrialNotefrom #966, so a test can reach it. The paywall it opens already offers only the upgrade to someone who bought a pack (PackOffer.itemsreturns[.upgrade]).The after-Take offers (
afterTakeOnDevice,afterTakeStopped) still readlicense(). That's right for them: the pack really gave that Take the Drive Copy and the names.Tests (AppTests/FirstShowOfferTests)
packOwnerGetsTheFirstShowOfferWithTheUpgrade: red first, with the seam still onlicense():✘ ... FirstShowOfferTests.swift:24:9: Expectation failed: offer(pro) == .firstShowEnded. It passes after the switch. Its second check (the paywall's items are[.upgrade]) passed already. It repeats a package test, but it covers the issue's "offers the upgrade" condition.proOwnerNeverGetsItandfreeUserStillGetsIt: passed on their first run. They are regression guards.Full
./scripts/verify.shpassed: macOS build and AppTests, iOS Simulator build, 139s.For Eric