Fix for calling two parameter version of ImGuiTextFilter::Draw() - #721
Merged
Merged
Conversation
…93.0) SetNextItemWidth() is available since 1.70 ocornut/imgui@a14bebd
Contributor
|
Ran into this as well. |
brenocq
added a commit
to brenocq/implot3d
that referenced
this pull request
Sep 24, 2026
ImGui removed the `float width` parameter of `ImGuiTextFilter::Draw()` (ocornut/imgui@a14bebd), so the two-argument call in the style editor fails to compile against recent ImGui builds that disable obsolete functions. Set the width with `ImGui::SetNextItemWidth()` before the one-argument call instead; it behaves identically and compiles on all supported ImGui versions. Mirrors the same fix in ImPlot (epezent/implot#721).
brenocq
approved these changes
Sep 24, 2026
brenocq
left a comment
brenocq
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the PR! Fix also implemented in ImPlot3D: brenocq/implot3d#196
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed in ocornut/imgui@a14bebd
SetNextItemWidth()is available since 1.70, so no need for version check.