Repository navigation
fix: calling two-parameter version of ImGuiTextFilter::Draw() - #196
Merged
Merged
Conversation
ImGui removed the `float width` parameter of `ImGuiTextFilter::Draw()` (ocornut/imgui@a14bebd), so the two-argument call in the style editor fails to compile against recent ImGui builds that disable obsolete functions. Set the width with `ImGui::SetNextItemWidth()` before the one-argument call instead; it behaves identically and compiles on all supported ImGui versions. Mirrors the same fix in ImPlot (epezent/implot#721).
brenocq
changed the title
github-actions
Bot
added
status:done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ImGui removed the
float widthparameter ofImGuiTextFilter::Draw()(ocornut/imgui@a14bebd), so the two-argument call in the style editor no longer compiles against recent ImGui when obsolete functions are disabled.Fixed by setting the width with
ImGui::SetNextItemWidth()before the one-argumentDraw()call — behavior-identical and valid on all supported ImGui versions. Mirrors the same fix in ImPlot (epezent/implot#721).