Skip to content

api: relax Headers validation #9681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sivchari wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −5
Open

api: relax Headers validation #9681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/v1alpha1/ratelimit_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ type RateLimitSelectCondition struct {
// meaning, a request MUST match all the specified headers.
//
// +optional
// +kubebuilder:validation:MaxItems=64
// +kubebuilder:validation:MaxItems=128

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 6, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add release-note fragment for this API change

This relaxes an existing CRD validation for RateLimitSelectCondition.headers, which is a user-visible API behavior change; this repo records such changes as per-change fragments under release-notes/current/<section>/, but this commit does not add one. Please add a fragment (likely under bug_fixes/ or other_changes/, depending on the intended classification) so the next release notes mention that policies with 65-128 header matches are now accepted.

Useful? React with 👍 / 👎.

Headers []HeaderMatch `json:"headers,omitempty"`

// Methods is a list of request methods to match. Multiple method values are ORed together,
Expand Down
4 changes: 2 additions & 2 deletions ...s/gateway-crds-helm/templates/generated/gateway.envoyproxy.io_backendtrafficpolicies.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1545,7 +1545,7 @@ spec:
required:
- name
type: object
maxItems: 64
maxItems: 128

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 6, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Regenerate Helm test golden files

Changing this CRD template means make gen-check will re-run helm-template and dirty the committed Helm goldens, but the rendered fixtures under test/helm/gateway-crds-helm still contain maxItems: 64 for the BackendTrafficPolicy header selector (for example envoy-gateway-crds.out.yaml and all.out.yaml). Please regenerate and commit those .out.yaml files so CI and consumers of the checked-in rendered output see the same 128-item limit.

Useful? React with 👍 / 👎.

type: array
methods:
description: |-
Expand Down Expand Up @@ -1956,7 +1956,7 @@ spec:
required:
- name
type: object
maxItems: 64
maxItems: 128
type: array
methods:
description: |-
Expand Down
4 changes: 2 additions & 2 deletions ...gateway-helm/charts/crds/crds/generated/gateway.envoyproxy.io_backendtrafficpolicies.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1544,7 +1544,7 @@ spec:
required:
- name
type: object
maxItems: 64
maxItems: 128
type: array
methods:
description: |-
Expand Down Expand Up @@ -1955,7 +1955,7 @@ spec:
required:
- name
type: object
maxItems: 64
maxItems: 128
type: array
methods:
description: |-
Expand Down
Loading