api: relax Headers validation - #9681
Conversation
Signed-off-by: sivchari <shibuuuu5@gmail.com>
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3575be4500
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| - name | ||
| type: object | ||
| maxItems: 64 | ||
| maxItems: 128 |
There was a problem hiding this comment.
Changing this CRD template means make gen-check will re-run helm-template and dirty the committed Helm goldens, but the rendered fixtures under test/helm/gateway-crds-helm still contain maxItems: 64 for the BackendTrafficPolicy header selector (for example envoy-gateway-crds.out.yaml and all.out.yaml). Please regenerate and commit those .out.yaml files so CI and consumers of the checked-in rendered output see the same 128-item limit.
Useful? React with 👍 / 👎.
| // | ||
| // +optional | ||
| // +kubebuilder:validation:MaxItems=64 | ||
| // +kubebuilder:validation:MaxItems=128 |
There was a problem hiding this comment.
This relaxes an existing CRD validation for RateLimitSelectCondition.headers, which is a user-visible API behavior change; this repo records such changes as per-change fragments under release-notes/current/<section>/, but this commit does not add one. Please add a fragment (likely under bug_fixes/ or other_changes/, depending on the intended classification) so the next release notes mention that policies with 65-128 header matches are now accepted.
Useful? React with 👍 / 👎.
|
can you rename the PR title and add a release notes for this? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9681 +/- ##
==========================================
+ Coverage 75.48% 76.18% +0.69%
==========================================
Files 252 261 +9
Lines 41642 43553 +1911
==========================================
+ Hits 31435 33180 +1745
- Misses 8075 8166 +91
- Partials 2132 2207 +75 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2 participants
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #9611
PR Checklist
git commit -s). See DCO: Sign your work./api), the API was discussed and agreed before the implementation. The API change can be in a separate PR, or in the same PR, but the API must be agreed before implementation. N/A if this PR does not contain API changes.make generate gen-check,make lint, and the unit-test/coverage build pass. (Flaky e2e failures are not considered breakages, butgen-check,lint, and coverage MUST pass.)release-notes/current/<section>/<pr-number>-<slug>.md(seerelease-notes/current/README.mdfor sections and naming). N/A if this PR does not contain non-trivial changes.make gen-checkand committed the result if API/helm charts/modules changed.release-notes/current/breaking_changes/.