Skip to content

fix(admin): keep rich-text formatting toolbar visible on long posts #1223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
scottbuscemi wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −2
Draft

fix(admin): keep rich-text formatting toolbar visible on long posts #1223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-sticky-editor-toolbar.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@emdash-cms/admin": patch
---

The rich-text editor formatting toolbar now stays pinned to the top of the editing area while scrolling through long posts, instead of scrolling out of view. The toolbar uses `position: sticky` and the editor wrapper switched from `overflow-hidden` to `overflow-clip` so corners stay clipped without creating a nested scroll container that would break sticky positioning. Distraction-free / minimal editors (e.g. Widgets) are unaffected since they don't render the toolbar.
4 changes: 2 additions & 2 deletions packages/admin/src/components/PortableTextEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2338,7 +2338,7 @@ export function PortableTextEditor({
return (
<div
className={cn(
"border rounded-lg overflow-hidden",
"border rounded-lg overflow-clip",
minimal && "border-0 rounded-none -mx-4",
focusMode === "spotlight" && "spotlight-mode",
className,
Expand Down Expand Up @@ -2794,7 +2794,7 @@ function EditorToolbar({
ref={toolbarRef}
role="toolbar"
aria-label={t`Text formatting`}
className="border-b bg-kumo-tint/50 p-1 flex flex-wrap gap-0.5"
className="sticky top-0 z-10 border-b bg-kumo-tint p-1 flex flex-wrap gap-0.5"
onKeyDown={handleKeyDown}
>
{/* Text formatting */}
Expand Down
Loading