fix(admin): keep rich-text formatting toolbar visible on long posts#1223
Draft
scottbuscemi wants to merge 1 commit into
Draft
fix(admin): keep rich-text formatting toolbar visible on long posts#1223scottbuscemi wants to merge 1 commit into
scottbuscemi wants to merge 1 commit into
Conversation
The editor toolbar scrolled out of view on long documents. Make it `sticky top-0` and switch the editor wrapper from `overflow-hidden` to `overflow-clip` so the rounded corners still clip without establishing a nested scroll container that breaks sticky positioning. The scroll container is the admin shell <main>, so top-0 pins it under the header. Closes #1192.
🦋 Changeset detectedLatest commit: 3df4b75 The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
emdash-demo-cache | 3df4b75 | May 29 2026, 10:19 PM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
emdash-playground | 3df4b75 | May 29 2026, 10:19 PM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
docs | 3df4b75 | May 29 2026, 10:20 PM |
Contributor
PR template validation failedPlease fix the following issues by editing your PR description:
See CONTRIBUTING.md for the full contribution policy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1192.
Problem
When editing long posts, the WYSIWYG formatting toolbar scrolled out of the viewport, forcing users to scroll back up to apply formatting.
Fix
EditorToolbarrootsticky top-0 z-10with an opaquebg-kumo-tintso content doesn't bleed through.overflow-hiddentooverflow-clip—overflow-hiddenestablished a nested scroll container that broke sticky positioning;overflow-clipstill clips the rounded corners without doing so.<main>(the app header sits outside it), sotop-0pins the toolbar directly under the header.Testing
pnpm lint:quickclean,pnpm --filter @emdash-cms/admin typecheckpasses.Manual verification