Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryThis PR merges the full
Confidence Score: 4/5Safe to merge with two known rough edges: the auto-continuation error path that silently drops the first-leg response on a mid-continuation failure, and the open-code-fence gap in the incompleteness heuristic. The bulk of the redesign is behaviorally correct and the prior-review fixes are all present. The chat continuation feature has a latent gap: when _callChatAPIWithContinuation throws a non-abort error on the second leg, aiMsgEl.textContent — which already contains the full first-leg response — is never pushed to chatHistory, so the user loses that text on reload. This path is exercised any time a network error or rate-limit hits a continuation request, which is more likely now that continuation fires automatically after every long response. js/chat.js — the sendChatMessage and runDiscussionRound non-AbortError catch blocks; service-worker.js — the expanded APP_SHELL list where a single bad path blocks install for new users. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Page load / DOMContentLoaded] --> B[primeSyncState]
B --> C[navigate to getInitialView]
C --> D{route valid?}
D -- no --> E[dashboard]
D -- yes --> F[restored last view]
E & F --> G[rAF + setTimeout 0]
G --> H[initSync deferred]
G --> I[ensureSNPTable deferred]
C --> J[renderChatMessages]
J --> K{chatHistory empty?}
K -- no --> L[show conversation]
K -- yes --> M{hasProfile?}
M -- no --> N[Stage 1: profile form]
M -- yes --> O{isAIPaused?}
O -- yes --> P[re-enable prompt]
O -- no --> Q{providerRequested in sessionStorage?}
Q -- yes --> R[Stage 2: provider quiz]
Q -- no --> S{hasData and extrasDone?}
S -- no --> T[Stage 3: context tasks]
T --> U[Connect AI sets sessionStorage flag]
U --> R
T --> W[Import labs via lazy loadPdfImport]
T --> X[Skip to extrasDone]
S -- yes --> Y[Stage 4: regular chat UI]
Reviews (8): Last reviewed commit: "Guard service worker cache writes" | Re-trigger Greptile |
|
Follow-up for Greptile full-branch review pushed in d56bb85. Fixed:
Verification after the fix:
Untracked local files remain excluded from the PR. |
|
Mobile theme chrome follow-up pushed in de1d0d7. Fixes the mobile system/browser navigation color drifting light under dark custom themes, especially
Verification:
|
Full Branch Review Request
This PR is the complete
redesignbranch intomain, not a single-commit follow-up. Please review the end-to-end branch diff across all commits and changed files.Scope at creation:
mainatc2a61d3redesignata97ca7cWhat Changed
Product redesign
dashboard.pngfor the repository page.Empty-state onboarding
Performance and loading
js/import-loader.js.Accessibility and quality
Review Focus
Please review the whole branch for:
Verification Run
node tests/test-chat-actions.jsnode tests/test-correctness-phase2.jsnode tests/test-sync.jsnpm testPORT=8000 node tests/test-dev-server-origin.jsPORT=8000 NODE_PATH=node_modules PUPPETEER_EXECUTABLE_PATH=/usr/bin/google-chrome node run-tests.jsgit diff --checkNotes
AGENTS.md,tests/test-theme-responsive-e2e.js.