Skip to content

Fix selection failures #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danirabbit merged 2 commits into from
May 22, 2026
Merged

Fix selection failures #325

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1fad8f7
fix: Device card_sink_port_name was not set when it could have
flodavid May 17, 2026
f26c0b1
fix: Input and Output were reversed when checking card profiles
flodavid May 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions src/Services/PulseAudioManager.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,13 @@ public class Sound.PulseAudioManager : GLib.Object {
// for example to switch between onboard speakers to hdmi
// the profile has to be switched from analog stereo to digital stereo.
// Attempt to find profiles that support both selected input and output
var other_device = default_input;
var card_name = "card-sink-name";
var other_device = default_output;
var direction_name = "source-name";
var card_direction_name = "card-source-name";
if (device.direction == OUTPUT) {
other_device = default_output;
card_name = "card-source-name";
other_device = default_input;
direction_name = "sink-name";
card_direction_name = "card-sink-name";
}

var profile_name = device.get_matching_profile (other_device);
Expand All @@ -99,7 +101,7 @@ public class Sound.PulseAudioManager : GLib.Object {
yield set_card_profile_by_index (device.card_index, profile_name);
// wait for new card sink to appear
debug ("wait for card sink / source");
yield wait_for_update (device, card_name);
yield wait_for_update (device, card_direction_name);
}

// #2 Set sink / source port
Expand All @@ -119,7 +121,7 @@ public class Sound.PulseAudioManager : GLib.Object {
if (device.direction == OUTPUT && device.sink_name == null ||
device.direction == INPUT && device.source_name == null) {
debug ("wait for sink / source");
yield wait_for_update (device, card_name);
yield wait_for_update (device, direction_name);
}

// #4 Set sink / source
Expand Down Expand Up @@ -463,8 +465,11 @@ public class Sound.PulseAudioManager : GLib.Object {
device.card_sink_name = sink.name;
debug ("\t\t\tdevice.card_sink_name: %s", device.card_sink_name);

if (sink.active_port != null && device.port_name == sink.active_port.name) {
if (sink.active_port != null) {
device.card_sink_port_name = sink.active_port.name;
}

if (sink.active_port != null && device.port_name == sink.active_port.name) {
device.sink_name = sink.name;
debug ("\t\t\tdevice.sink_name: %s", device.card_sink_name);
device.sink_index = (int)sink.index;
Expand Down