Fix selection failures - #325
Merged
Merged
Conversation
Not setting card_sink_port_name could induce failure of PulseAudioManager.set_default_device (). Action elementary#2 "Set sink / source port" was not triggered. Then action elementary#3 "Wait for sink / source" failed and the default device was not set in the end.
flodavid
marked this pull request as draft
May 17, 2026 03:17
This could prevent selection of devices with multiple outputs. It was introduced by elementary#293.
flodavid
force-pushed
the
fix-selection-failures
branch
from
May 19, 2026 20:28
20144d4 to
dd63bbe
Compare
flodavid
marked this pull request as ready for review
May 19, 2026 20:40
danirabbit
reviewed
May 21, 2026
flodavid
force-pushed
the
fix-selection-failures
branch
from
May 22, 2026 18:17
dd63bbe to
f26c0b1
Compare
danirabbit
approved these changes
May 22, 2026
danirabbit
left a comment
danirabbit
left a comment
Member
There was a problem hiding this comment.
Looks good to me. Nice fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current behaviour of the output list is very spotty, especially for devices with multiples inputs/outputs.
This PR addresses this, with two fixes. It resolves #223.
With both fixes, output selection is now working correctly even when the device has multiple outputs or some input. The behaviour is now the same as in sound settings.
First fix: Device card_sink_port_name was not set when it could have.
Not setting card_sink_port_name could induce failure of
PulseAudioManager.set_default_device ().Hence action #2 "Set sink / source port" was not triggered.
Then action #3 "Wait for sink / source" failed and the default device was not set.
This would result in a selection of an of the output of a device with multiple ones to not have any effect (only one is working, without a way to know which one).
Second fix: Input and Output were reversed when checking card profiles
Selection of an output of devices with some input may not have any effect because of this.
It was introduced by #293.